[libvirt] [PATCH] tests: skip virfirewalltest on non-Linux systems

Roman Bogorodskiy bogorodskiy at gmail.com
Fri May 2 09:52:40 UTC 2014


  Peter Krempa wrote:

> On 05/02/14 11:37, Daniel P. Berrange wrote:
> > On Thu, May 01, 2014 at 10:51:02PM +0400, Roman Bogorodskiy wrote:
> >> Currently firewalling is supported on Linux only, so skip the
> >> virfirewalltest on other platforms.
> >> ---
> >>  tests/virfirewalltest.c | 58 +++++++++++++++++++++++++++++--------------------
> >>  1 file changed, 35 insertions(+), 23 deletions(-)
> > 
> > This code is actually intended to be portable across all platforms.
> > 
> > What actual problem are you seeing.
> 
> There were build failures with the new test, but according to our build
> systems they should be fixed now by a few patches from Pavel and Jan so
> there shouldn't be a need to skip the test now.
> 
> Roman, could you please re-try running it with the current HEAD? (last
> patch went in just recently)

The test still fails on current HEAD.

Roman Bogorodskiy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140502/bcdc3fcc/attachment-0001.sig>


More information about the libvir-list mailing list