[libvirt] [PATCH] tests: skip virfirewalltest on non-Linux systems

[Daniel P. Berrange]

On Fri, May 02, 2014 at 11:52:28AM +0200, Ján Tomko wrote:
> On 05/02/2014 11:37 AM, Daniel P. Berrange wrote:
> > On Thu, May 01, 2014 at 10:51:02PM +0400, Roman Bogorodskiy wrote:
> >> Currently firewalling is supported on Linux only, so skip the
> >> virfirewalltest on other platforms.
> >> ---
> >>  tests/virfirewalltest.c | 58 +++++++++++++++++++++++++++++--------------------
> >>  1 file changed, 35 insertions(+), 23 deletions(-)
> > 
> > This code is actually intended to be portable across all platforms.
> > 
> > What actual problem are you seeing.
> > 
> 
> virFirewallValidateBackend checks for the presence of iptables and ebtables.
> This also breaks starting networks without ebtables installed, even if
> mac_filter is turned off.
> 
> Would it be OK to remove this check and only fail when the commands are
> actually executed?

OH, I forgot about that check. It is actually intentional to check it
upfront because it gives us better error reporting to have it done when
the virFirewall instance is created

Just disabling the test probably is the right answer until we add a
backend that checks for BSD tools.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|