[libvirt] [PATCH 1/2] virsh: Replace list element to defined variable

Eric Blake eblake at redhat.com
Mon May 5 19:51:54 UTC 2014


On 04/28/2014 08:10 PM, Li Yang wrote:
> Signed-off-by: Li Yang <liyang.fnst at cn.fujitsu.com>
> ---
>  tools/virsh-secret.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/tools/virsh-secret.c b/tools/virsh-secret.c
> index 47974fe..e996c72 100644
> --- a/tools/virsh-secret.c
> +++ b/tools/virsh-secret.c
> @@ -558,7 +558,7 @@ cmdSecretList(vshControl *ctl, const vshCmd *cmd ATTRIBUTE_UNUSED)

Additional context:

    for (i = 0; i < list->nsecrets; i++) {
        virSecretPtr sec = list->secrets[i];


>          const char *usageStr = virSecretUsageTypeTypeToString(usageType);
>          char uuid[VIR_UUID_STRING_BUFLEN];
>  
> -        if (virSecretGetUUIDString(list->secrets[i], uuid) < 0) {
> +        if (virSecretGetUUIDString(sec, uuid) < 0) {

No semantic difference.  But doesn't hurt, so ACK and pushed.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140505/23df582e/attachment-0001.sig>


More information about the libvir-list mailing list