[libvirt] [libvirt PATCH] udev: consider the device a CDROM when ID_CDROM=1

Eric Blake eblake at redhat.com
Tue May 6 22:28:38 UTC 2014


On 05/06/2014 05:11 AM, Giuseppe Scrivano wrote:
> "Daniel P. Berrange" <berrange at redhat.com> writes:
> 
>> On Wed, Apr 23, 2014 at 12:42:01PM +0200, Giuseppe Scrivano wrote:
>>> Some CDROM devices are reported by udev to have an ID_TYPE="generic"
>>> thus it is necessary to check if ID_CDROM is present.
>>>
>>> As a side effect, treating ID_TYPE="generic" as a missing ID_TYPE will
>>> enable checks for ID_DRIVE_FLASH_SD and ID_DRIVE_FLOPPY and the
>>> udevKludgeStorageType heuristic.
>>>
>>> Signed-off-by: Giuseppe Scrivano <gscrivan at redhat.com>
>>> ---
>>>  src/node_device/node_device_udev.c | 11 +++++++++--
>>>  1 file changed, 9 insertions(+), 2 deletions(-)
>>
>> ACK
> 
> Thanks.
> 
> Can somebody please push the patch as I've no write access to the repo?

Done.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140506/87faf2ff/attachment-0001.sig>


More information about the libvir-list mailing list