[libvirt] [PATCH 4/4] parallels: add a set of trivial functions

[Dmitry Guryanov]

On Wednesday 07 May 2014 14:55:51 Daniel P. Berrange wrote:
> On Wed, Apr 23, 2014 at 06:35:03PM +0400, Dmitry Guryanov wrote:
> > Add functions parallelsIsAlive, parallelsIsEncrypted,
> > parallelsIsSecure which are very simple to implement, but
> > may be required by some libvirt users. Almost all other
> > drivers have these functions.
> > 
> > Signed-off-by: Dmitry Guryanov <dguryanov at parallels.com>
> > ---
> > 
> >  src/parallels/parallels_driver.c | 20 ++++++++++++++++++++
> >  1 file changed, 20 insertions(+)
> > 
> > diff --git a/src/parallels/parallels_driver.c
> > b/src/parallels/parallels_driver.c index 4ab3e1c..54d67a2 100644
> > --- a/src/parallels/parallels_driver.c
> > +++ b/src/parallels/parallels_driver.c
> > @@ -2362,6 +2362,23 @@ parallelsNodeGetInfo(virConnectPtr conn
> > ATTRIBUTE_UNUSED,> 
> >      return nodeGetInfo(nodeinfo);
> >  
> >  }
> > 
> > +static int parallelsConnectIsEncrypted(virConnectPtr conn
> > ATTRIBUTE_UNUSED) +{
> > +    /* Encryption is not relevant / applicable to way we talk to PCS */
> > +    return 0;
> > +}
> > +
> > +static int parallelsConnectIsSecure(virConnectPtr conn ATTRIBUTE_UNUSED)
> > +{
> > +    /* We run CLI tools directly so this is secure */
> > +    return 1;
> > +}
> > +
> > +static int parallelsConnectIsAlive(virConnectPtr conn ATTRIBUTE_UNUSED)
> > +{
> > +    return 1;
> > +}
> > +
> > 
> >  static virDriver parallelsDriver = {
> >  
> >      .no = VIR_DRV_PARALLELS,
> > 
> > @@ -2392,6 +2409,9 @@ static virDriver parallelsDriver = {
> > 
> >      .domainShutdown = parallelsDomainShutdown, /* 0.10.0 */
> >      .domainCreate = parallelsDomainCreate,    /* 0.10.0 */
> >      .domainDefineXML = parallelsDomainDefineXML,      /* 0.10.0 */
> > 
> > +    .connectIsEncrypted = parallelsConnectIsEncrypted, /* 1.2.4 */
> > +    .connectIsSecure = parallelsConnectIsSecure, /* 1.2.4 */
> > +    .connectIsAlive = parallelsConnectIsAlive, /* 1.2.4 */
> > 
> >  };
> 
> ACK, though I'll tweak the version to 1.2.5 before pushing to GIT.

Thanks!

> 
> Regards,
> Daniel

-- 
Dmitry Guryanov