[libvirt] [PATCH] qemu: Avoid leak in qemuDomainCheckRemoveOptionalDisk

Jiri Denemark jdenemar at redhat.com
Thu May 15 13:46:19 UTC 2014


On Thu, May 15, 2014 at 14:16:51 +0200, Martin Kletzander wrote:
> On Thu, May 15, 2014 at 01:20:39PM +0200, Jiri Denemark wrote:
> >Coverity complains about event being leaked in
> >qemuDomainCheckRemoveOptionalDisk. The best fix for it is to avoid
> >searching for the disk (using its srouce path even) we got by walking
> 
> s/srouce/source/ , but the whole sentence is hard to read, just "The
> best fix for it is to remove it by its index.", and you can add ",
> which is also safer" if you want ;)
> 
> ACK with at lease the spelling fixed, it fixes an issue with multiple
> disks using the same non-existing file path also.

Thanks, I made the commit message better (hopefully) and pushed the
patch.

Jirka




More information about the libvir-list mailing list