[libvirt] [PATCH 0/4] more enum cleanups

Michal Privoznik mprivozn at redhat.com
Fri May 16 04:37:46 UTC 2014


On 15.05.2014 00:45, Eric Blake wrote:
> Inspired by the cleanups contributed by Julio Faracco, I did some
> more cleanups of my own.  My end goal is to turn on a syntax-check
> rule that forbids 'enum vir' (since we should always be declaring
> 'typedef enum { ... } vir...;'), but there's still a lot of
> violations in the code base, even after this series.
>
> Eric Blake (4):
>    vbox: fix stale comment about vdi storage type
>    maint: use enum typedef for virstorageencryption.h
>    maint: shorten 'TypeType' function names
>    maint: prefer enum over int for virstoragefile structs
>
>   src/conf/domain_conf.c             | 14 +++++++-------
>   src/conf/domain_conf.h             |  2 +-
>   src/conf/secret_conf.c             |  8 ++++----
>   src/conf/secret_conf.h             |  4 ++--
>   src/conf/storage_conf.c            | 14 +++++++-------
>   src/conf/storage_conf.h            |  6 +++---
>   src/libvirt_private.syms           | 10 +++++-----
>   src/lxc/lxc_controller.c           |  2 +-
>   src/qemu/qemu_command.c            |  8 ++++++++
>   src/qemu/qemu_driver.c             |  8 ++++----
>   src/storage/storage_backend_disk.c |  2 +-
>   src/util/virstorageencryption.c    |  6 +++---
>   src/util/virstorageencryption.h    | 10 +++++-----
>   src/util/virstoragefile.h          | 19 ++++++++++---------
>   src/vbox/vbox_tmpl.c               | 15 ++++-----------
>   tools/virsh-secret.c               |  4 ++--
>   16 files changed, 67 insertions(+), 65 deletions(-)
>

ACK to all.

Michal




More information about the libvir-list mailing list