[libvirt] [PATCH] Revert "maint: prefer enum over int for virstoragefile structs"
Eric Blake
eblake at redhat.com
Mon May 19 15:13:35 UTC 2014
On 05/17/2014 01:05 AM, Roman Bogorodskiy wrote:
> Eric Blake wrote:
>
>> This partially reverts commits b279e52f7 and ea18f8b2.
>>
>> It turns out our code base is full of:
>>
>> if ((struct.member = virBlahFromString(str)) < 0)
>> goto error;
>>
>
> This patch fixes the problem for me and the approach looks good,
> as other workarounds look quite ugly indeed.
Thanks; pushed. Sorry for leaving the build broken over a weekend.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140519/e040bebb/attachment-0001.sig>
More information about the libvir-list
mailing list