[libvirt] [PATCH 4/4] qemu: snapshot: Fix return value of external checkpoint with no disks

[Peter Krempa]

On 05/20/14 16:28, Eric Blake wrote:
> On 05/20/2014 07:36 AM, Peter Krempa wrote:
>> When doing an external checkpoint of a VM with no disk selected we'd
>> return failure but not set error code. This was a result of ret not
>> being set to 0 during walking of the disk array.
>>
>> Rework early failure checking to avoid the problem.
>>
>> Fixes the following symptom (or without --diskspec for diskless VMs)
>>
>>  $ virsh snapshot-create-as snapshot-test  --memspec /tmp/asdf --diskspec hda,snapshot=no
>>  error: An error occurred, but the cause is unknown
>> ---
> 
> Technically, this is equivalent to a 'virsh save'.  Would it be better
> to avoid an error altogether and allow the operation as a longhand
> spelling of the same action?
> 

virsh save kills the VM after it finishes. This allows to preserve the
VM running and also allows snapshots of diskless VMs.

Peter

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 901 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140520/785055f3/attachment-0001.sig>