[libvirt] [PATCH 4/4] qemu: snapshot: Fix return value of external checkpoint with no disks

[Eric Blake]

On 05/20/2014 10:16 AM, Eric Blake wrote:
> 
> Adding an option to 'virsh save' to not kill the guest doesn't make much
> sense in general,

because memory state without matching disk state can't be used to resume
a guest.

> but might make sense for a diskless VM.  Meanwhile,
> don't we already have the option to kill or keep the guest alive after
> an external memory snapshot?

Here, I was thinking of VIR_DOMAIN_SNAPSHOT_CREATE_HALT.

Thus, 'virsh save $dom $file' appears to be shorthand for diskless
'virsh snapshot-create-as $dom --halt --memspec $file'

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140520/fc6132c5/attachment-0001.sig>