[libvirt] [PATCH] bhyve: domain events support

[Roman Bogorodskiy]

  Daniel P. Berrange wrote:

> On Wed, Apr 23, 2014 at 07:50:09PM +0400, Roman Bogorodskiy wrote:
> > Support events for these functions:
> > 
> >  - domainDefineXML
> >  - domainUndefine
> >  - domainCreate{WithFlags,XML}
> >  - domainDestroy
> > ---
> >  src/bhyve/bhyve_driver.c | 88 +++++++++++++++++++++++++++++++++++++++++++++++-
> >  src/bhyve/bhyve_utils.h  |  3 ++
> >  2 files changed, 90 insertions(+), 1 deletion(-)
> 
> ACK, with one tweak
> 
> > @@ -727,8 +746,16 @@ bhyveDomainCreateWithFlags(virDomainPtr dom,
> >                                 VIR_DOMAIN_RUNNING_BOOTED,
> >                                 start_flags);
> >  
> > +    if (ret == 0) {
> > +        event = virDomainEventLifecycleNewFromObj(vm,
> > +                                                  VIR_DOMAIN_EVENT_STARTED,
> > +                                                  VIR_DOMAIN_EVENT_STARTED_BOOTED);
> > +    }
> 
> Nit-pick - no need for curly brackets here

Pushed with this fix and s/1.2.4/1.2.5/ for the new functions; thanks!

Roman Bogorodskiy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140520/094e2312/attachment-0001.sig>