[libvirt] [RFC PATCH 0/5] another <disk> refactoring

Eric Blake eblake at redhat.com
Thu May 22 04:50:43 UTC 2014


I'm about to reuse the <mirror> sub-element of <disk> for my
pending series on active block commit, but to do that, I
wanted to get some refactoring out of the way first.  Patches
1-4 are pretty straightforward, and 5 may be controversial
(I'm sending it now, even though it still needs more work, to
make sure I'm not doing something bad).  I'm aware that this
will probably cause some rebase pain for Peter's work with
gluster, but at the same time, it will ease some of the work
that Benoit wants for introducing quorums.

Eric Blake (5):
  conf: store snapshot source as pointer, for easier manipulation
  conf: consolidate disk def allocation
  conf: store disk source as pointer, for easier manipulation
  conf: store mirroring information in virStorageSource
  conf: alter disk mirror xml output

 docs/schemas/domaincommon.rng                      |  29 +-
 src/conf/domain_conf.c                             | 254 ++++++++------
 src/conf/domain_conf.h                             |   6 +-
 src/conf/snapshot_conf.c                           |  56 ++--
 src/conf/snapshot_conf.h                           |   2 +-
 src/libvirt_private.syms                           |   1 +
 src/lxc/lxc_controller.c                           |   8 +-
 src/lxc/lxc_driver.c                               |   8 +-
 src/parallels/parallels_driver.c                   |   2 +-
 src/qemu/qemu_command.c                            | 290 ++++++++--------
 src/qemu/qemu_conf.c                               |  88 ++---
 src/qemu/qemu_domain.c                             |  18 +-
 src/qemu/qemu_driver.c                             | 372 +++++++++++----------
 src/qemu/qemu_migration.c                          |   4 +-
 src/qemu/qemu_process.c                            |   8 +-
 src/security/security_selinux.c                    |   4 +-
 src/vbox/vbox_tmpl.c                               |   6 +-
 src/vmx/vmx.c                                      |   2 +-
 src/xenxs/xen_sxpr.c                               |   8 +-
 src/xenxs/xen_xm.c                                 |   4 +-
 .../qemuxml2argv-disk-mirror-old.xml               |  47 +++
 .../qemuxml2argvdata/qemuxml2argv-disk-mirror.xml  |   9 +-
 .../qemuxml2xmlout-disk-mirror-old-inactive.xml    |  41 +++
 .../qemuxml2xmlout-disk-mirror-old.xml             |  52 +++
 tests/qemuxml2xmltest.c                            |   1 +
 tests/securityselinuxlabeltest.c                   |   6 +-
 26 files changed, 778 insertions(+), 548 deletions(-)
 create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-mirror-old.xml
 create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-disk-mirror-old-inactive.xml
 create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-disk-mirror-old.xml

-- 
1.9.0




More information about the libvir-list mailing list