[libvirt] [PATCH] Remove unsupported type sdl from error info when set 2 vnc or spice graphics

[Peter Krempa]

On 05/23/14 11:26, Daniel P. Berrange wrote:
> On Fri, May 23, 2014 at 05:23:36PM +0800, tzheng at redhat.com wrote:
>> ---
>>  src/qemu/qemu_command.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
>> index 193959f..a146463 100644
>> --- a/src/qemu/qemu_command.c
>> +++ b/src/qemu/qemu_command.c
>> @@ -8579,7 +8579,7 @@ qemuBuildCommandLine(virConnectPtr conn,
>>      if (sdl > 1 || vnc > 1 || spice > 1) {
>>          virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
>>                         _("only 1 graphics device of each type "
>> -                         "(sdl, vnc, spice) is supported"));
>> +                         "(vnc, spice) is supported"));
>>          goto error;
>>      }
> 
> What makes you think SDL is unsupported ?
> 

It's unsupported in rhel-7 (
https://bugzilla.redhat.com/show_bug.cgi?id=1100634 ). Upstream we do
support it.

NACK to the patch.

> Regards,
> Daniel
> 

Peter

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 901 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140523/aa20d89d/attachment-0001.sig>