[libvirt] [PATCH] Explicitly pin hotplugged vcpu to all cpus

[Peter Krempa]

On 05/23/14 14:37, Ján Tomko wrote:
> QEMU does not join vcpu threads after vcpu hotunplug.
> The thread might stay pinned when we hotplug the cpu again.
> 
> We were already pinning the hotplugged vcpus when a per-domain
> pinning was specified.
> 
> Explicitly pin the hotplugged vcpu to all cpus if there is no
> cpuset specified in domain XML, to make sure the vcpupin
> stays accurate.
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=1099836
> ---
>  src/qemu/qemu_driver.c | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
> 

The statements about qemu are true only for the downstream version.
Upstream qemu promises that it will clean up the threads once they
implement vCPU hot unplug so we will not need to execute the code you've
proposed in upstream.

NACK for merging this upstream.

Peter


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 901 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140523/6263e4ef/attachment-0001.sig>