[libvirt] [PATCH 3/3] tests: add test case for -serial option for ppce500

[Hong-Hua.Yin at freescale.com]

Hi Jan,

You're right. It should be QEMU_CAPS_DEVICE other than QEMU_CAPS_DRIVE.

Best Regards,
Olivia

> -----Original Message-----
> From: Ján Tomko [mailto:jtomko at redhat.com]
> Sent: Monday, May 26, 2014 7:37 PM
> To: Yin Olivia-R63875; libvir-list at redhat.com
> Subject: Re: [libvirt] [PATCH 3/3] tests: add test case for -serial option
> for ppce500
> 
> On 05/22/2014 12:55 PM, Olivia Yin wrote:
> > ---
> >  .../qemuxml2argv-ppce500-serial.args               |  7 ++++++
> >  .../qemuxml2argv-ppce500-serial.xml                | 26
> ++++++++++++++++++++++
> >  tests/qemuxml2argvtest.c                           |  1 +
> >  3 files changed, 34 insertions(+)
> >  create mode 100644
> > tests/qemuxml2argvdata/qemuxml2argv-ppce500-serial.args
> >  create mode 100644
> > tests/qemuxml2argvdata/qemuxml2argv-ppce500-serial.xml
> >
> 
> This test passes even without applying the previous patches...
> 
> > diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c index
> > 1ea7bf8..b2aa22a 100644
> > --- a/tests/qemuxml2argvtest.c
> > +++ b/tests/qemuxml2argvtest.c
> > @@ -1279,6 +1279,7 @@ mymain(void)
> >              QEMU_CAPS_DEVICE_VIRTIO_RNG,
> > QEMU_CAPS_OBJECT_RNG_RANDOM);
> >
> >      DO_TEST("ppc-dtb", QEMU_CAPS_KVM, QEMU_CAPS_DTB);
> > +    DO_TEST("ppce500-serial", QEMU_CAPS_KVM, QEMU_CAPS_DRIVE,
> > + QEMU_CAPS_CHARDEV);
> 
> ... because the QEMU_CAPS_DEVICE capability is missing.
> 
> >
> >      DO_TEST("tpm-passthrough", QEMU_CAPS_DEVICE,
> >              QEMU_CAPS_DEVICE_TPM_PASSTHROUGH,
> > QEMU_CAPS_DEVICE_TPM_TIS);
> >
> 
> Jan