[libvirt] [PATCHv2 21/33] util: string: Return element count from virStringSplit

Eric Blake eblake at redhat.com
Wed May 28 02:23:54 UTC 2014


On 05/22/2014 07:48 AM, Peter Krempa wrote:
> To allow using the array manipulation macros on the arrays returned by
> virStringSplit we need to know the count of the elements in the array.
> Modify virStringSplit to return this value, rename it and add a helper
> with the old name so that we don't need to update all the code.
> ---
>  src/libvirt_private.syms |  1 +
>  src/util/virstring.c     | 24 ++++++++++++++++++++----
>  src/util/virstring.h     |  6 ++++++
>  3 files changed, 27 insertions(+), 4 deletions(-)

Makes sense, but you should also enhance tests/virstringtest.c to cover
the new function.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140527/f242776c/attachment-0001.sig>


More information about the libvir-list mailing list