[libvirt] [PATCH 2/3] storage: fs: Drop-in replace use of virStorageFileGetMetadataFromBuf

Eric Blake eblake at redhat.com
Wed May 28 16:46:28 UTC 2014


On 05/28/2014 08:16 AM, Peter Krempa wrote:
> Use virStorageFileGetMetadataFromFD instead in
> virStorageBackendProbeTarget as it now returns all required data and the
> storage file is already open in a filedescriptor.
> 
> Also fix improper error code being returned when virFileReadHeaderFD
> would fail as virStorageBackendUpdateVolTargetInfoFD would set the
> return code to 0.
> ---
>  src/storage/storage_backend_fs.c | 20 +++++++-------------
>  1 file changed, 7 insertions(+), 13 deletions(-)
> 

ACK.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140528/3141d064/attachment-0001.sig>


More information about the libvir-list mailing list