[libvirt] [PATCH 1/2] qemu: snapshot: Reject internal active snapshot without memory state

Peter Krempa pkrempa at redhat.com
Thu May 29 15:05:49 UTC 2014


On 05/29/14 16:36, Eric Blake wrote:
> On 05/29/2014 03:07 AM, Peter Krempa wrote:
>> A internal snapshot of a active VM with the memory snapshot disabled
>> explicitly would actually still take the memory snapshot. Reject it
>> explicitly.
>>
>> Before:
>>  $ virsh snapshot-create-as --domain VM --diskspec vda,snapshot=internal --memspec snapshot=no
>>  Domain snapshot 1401353155 created
>>
>> After:
>>  $ virsh snapshot-create-as --domain VM --diskspec vda,snapshot=internal --memspec snapshot=no
>>  error: Operation not supported: internal snapshot of a running VM must include the memory state
> 
> Technically, qemu 1.7 added blockdev-snapshot-internal-sync, so we CAN
> take internal disk-only snapshots now.  But as that is more complex to
> implement, I agree with this patch as an intermediate fix (and we'll
> still have to keep this code path for qemu 1.6 and earlier, based on a
> qemu_capabilities.h bit).
> 
>>
>> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1083345
>> ---
>>  src/qemu/qemu_driver.c | 9 +++++++++
>>  1 file changed, 9 insertions(+)
> 
> ACK, safe for 1.2.5.
> 

Pushed; Thanks.

I'll open a BZ to track the addition.

Peter

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 901 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140529/fc2dcf3c/attachment-0001.sig>


More information about the libvir-list mailing list