[libvirt] [libvirt-sandbox][PATCH 3/4] m4: sync macros with libvirt

Martin Kletzander mkletzan at redhat.com
Wed Nov 5 10:00:46 UTC 2014

On Tue, Nov 04, 2014 at 03:40:50PM +0100, Michal Privoznik wrote:
>The macros under the m4 directory are outdated a bit. When trying
>to compile with newer gcc I see some errors:
>make[4]: Entering directory '/home/zippy/work/libvirt/libvirt-sanbox.git/libvirt-sandbox'
>  CC       libvirt_sandbox_1_0_la-libvirt-sandbox-main.lo
>gcc: warning: switch '-Wmudflap' is no longer supported
>Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> m4/manywarnings.m4          | 217 ++++++++++++++++++++++++++++----------------
> m4/virt-compile-warnings.m4 | 216 +++++++++++++++++++++++++++++++------------
> m4/warnings.m4              |  82 +++++++++++++----
> 3 files changed, 361 insertions(+), 154 deletions(-)
>diff --git a/m4/virt-compile-warnings.m4 b/m4/virt-compile-warnings.m4
>index 894ab59..532a777 100644
>--- a/m4/virt-compile-warnings.m4
>+++ b/m4/virt-compile-warnings.m4
>@@ -2,7 +2,7 @@ dnl
> dnl Enable all known GCC compiler warnings, except for those
> dnl we can't yet cope with
> dnl

This function changed its name due to the overwrite and ./configure
now yells an error, but it doesn't fail, so it's easy to miss.

apart from this particular file, which is specific for libvirt-related
projects, it's ok to sync the rest with gnulib, as it's being done on
regular (or rather irregular) basis.

So partial ACK for m4/manywarnings.m4 and m4/warnings.m4 only.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20141105/bb7a8428/attachment-0001.sig>

More information about the libvir-list mailing list