[libvirt] [PATCH 3/3] qemuxml2argvmock: Mock virNumaNodesetIsAvailable

Michal Privoznik mprivozn at redhat.com
Wed Nov 5 17:07:18 UTC 2014

And yet again one fix of 90286418. The problem is, if libvirt is
built with NUMA disabled (--without-numad --without-numactl), the
testsuite doesn't count on that and some tests fail. This is
because the virNumaNodesetIsAvailable() function is taken from
another section of virnuma.c which contains functions stubs for
case NUMA is disabled at build time. And the function basically
yields an error. However, we want our testsuite to be
deterministic and hence we ought to mock the function.

Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
 tests/qemuxml2argvmock.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/tests/qemuxml2argvmock.c b/tests/qemuxml2argvmock.c
index 7218747..7b8bdd6 100644
--- a/tests/qemuxml2argvmock.c
+++ b/tests/qemuxml2argvmock.c
@@ -39,3 +39,12 @@ virNumaGetMaxNode(void)
    return maxnodesNum;
+virNumaNodesetIsAvailable(virDomainNumatunePtr numatune)
+    int maxGuestNode = virDomainNumatuneSpecifiedMaxNode(numatune);
+    int maxHostNode = virNumaGetMaxNode();
+    return maxGuestNode <= maxHostNode;

More information about the libvir-list mailing list