[libvirt] [PATCH] network: fix call virNetworkEventLifecycleNew when networkStartNetwork fail

Martin Kletzander mkletzan at redhat.com
Thu Nov 6 13:57:34 UTC 2014


On Sat, Nov 01, 2014 at 06:03:23PM +0800, Luyao Huang wrote:
>When start a network fail, libvirt still call virNetworkEventLifecycleNew
>to send a event.
>
>Signed-off-by: Luyao Huang <lhuang at redhat.com>
>---
> src/network/bridge_driver.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c
>index 10ded33..11e86e0 100644
>--- a/src/network/bridge_driver.c
>+++ b/src/network/bridge_driver.c
>@@ -3253,7 +3253,8 @@ static int networkCreate(virNetworkPtr net)
>     if (virNetworkCreateEnsureACL(net->conn, network->def) < 0)
>         goto cleanup;
>
>-    ret = networkStartNetwork(driver, network);
>+    if ((ret = networkStartNetwork(driver, network)) < 0)
>+        goto cleanup;
>
>     event = virNetworkEventLifecycleNew(network->def->name,
>                                         network->def->uuid,
>--
>1.8.3.1
>

ACK && will push in a while,

Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20141106/bc85bbf1/attachment-0001.sig>


More information about the libvir-list mailing list