[libvirt] [PATCH] Fix a mismatch attribute name

lhuang lhuang at redhat.com
Fri Nov 7 09:55:53 UTC 2014


On 11/07/2014 05:45 PM, Eric Blake wrote:
> On 11/07/2014 10:37 AM, lhuang wrote:
>> On 11/07/2014 05:15 PM, Eric Blake wrote:
>>> On 11/07/2014 09:24 AM, Luyao Huang wrote:
>>>> >From libvirt.org we know this attribute named:
>>>>
>>>> interface_mac    MAC address of the network interface, not unique
>>> Shouldn't we instead be fixing the docs to match the code?  Changing the
>>> code now may break existing implementations that have used the name in
>>> the current code.
>> yes, i agree with you, i give a v2 patch, but i don't know how to change
>> the doc in http://libvirt.org.
> libvirt.org autogenerates from the latest libvirt.git, at least once an
> hour.
>
>
>> https://www.redhat.com/archives/libvir-list/2014-November/msg00209.html
> So once that message is committed, the web page will auto-update.
Oh, I see, thanks
>> And this patch is for the bug:
>>
>> https://bugzilla.redhat.com/show_bug.cgi?id=1161358
> Then mention that in the commit message :)
>
Okay and thanks for push the patch :)




More information about the libvir-list mailing list