[libvirt] [PATCH v6 6/7] qemu: Add bps_max and friends to qemu command generation

[Michal Privoznik]

On 29.10.2014 13:16, Matthias Gatto wrote:
> Check the arability of the options with the current qemu binary,
> add them in the varable opt if yes, print a message if not.
>
> Signed-off-by: Matthias Gatto <matthias.gatto at outscale.com>
> ---
>   src/qemu/qemu_command.c | 57 ++++++++++++++++++++++++++++++++++++++++++++++++-
>   1 file changed, 56 insertions(+), 1 deletion(-)
>
> diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
> index 2e5af4f..b3dc919 100644
> --- a/src/qemu/qemu_command.c
> +++ b/src/qemu/qemu_command.c
> @@ -3669,12 +3669,32 @@ qemuBuildDriveStr(virConnectPtr conn,
>           goto error;
>       }
>
> +    /* block I/O throttling 1.7 */
> +    if ((disk->blkdeviotune.total_bytes_sec_max ||
> +         disk->blkdeviotune.read_bytes_sec_max ||
> +         disk->blkdeviotune.write_bytes_sec_max ||
> +         disk->blkdeviotune.total_iops_sec_max ||
> +         disk->blkdeviotune.read_iops_sec_max ||
> +         disk->blkdeviotune.write_iops_sec_max) &&
> +        !virQEMUCapsGet(qemuCaps, QEMU_CAPS_DRIVE_IOTUNE_MAX)) {
> +        virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
> +                       _("there is some block I/O throttling paramater that are not supported with this "
> +                         "QEMU binary(need QEMU 1.7 or superior)"));
> +        goto error;

This is rather a long line. Can you split it better, so that it has max 
~80 characters?

> +    }
> +


Michal