[libvirt] [PATCH v2] qemu: Don't try to parse -help for new QEMU
Jiri Denemark
jdenemar at redhat.com
Thu Nov 13 23:24:30 UTC 2014
On Thu, Nov 13, 2014 at 14:57:57 -0700, Eric Blake wrote:
> On 11/13/2014 01:39 PM, Jiri Denemark wrote:
> > Since QEMU 1.2.0, we switched to QMP probing instead of parsing -help
> > (and other commands, such as -cpu ?) output. However, if QMP probing
> > failed, we still tried starting QEMU with various options and parsing
> > the output, which was guaranteed to fail because the output changed.
> > Let's just refuse parsing -help for QEMU >= 1.2.0.
> >
> > https://bugzilla.redhat.com/show_bug.cgi?id=1160318
> > Signed-off-by: Jiri Denemark <jdenemar at redhat.com>
> > ---
> >
> > Notes:
> > Version 2:
> > - fixes comparison to avoid parsing -help for 1.2.0 (> vs >=)
>
> ACK.
Pushed, thanks.
Jirka
More information about the libvir-list
mailing list