[libvirt] [PATCH 1/2] virdbus: don't force users to pass int for bool values

Conrad Meyer cemeyer at uw.edu
Thu Nov 20 15:12:40 UTC 2014


Hi Eric,

I think this change breaks build on FreeBSD:

  CC       util/libvirt_util_la-virdbus.lo
util/virdbus.c:956:13: error: cast from 'bool *' to 'dbus_bool_t *' (aka 'unsigned int *') increases required alignment from 1 to 4 [-Werror,-Wcast-align]
            GET_NEXT_VAL(dbus_bool_t, bool_val, bool, "%d");
            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
util/virdbus.c:858:17: note: expanded from macro 'GET_NEXT_VAL'
            x = (dbustype *)(*xptrptr + (*narrayptr - 1));              \
                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 error generated.

(CC is Clang.)

Thanks,
Conrad




More information about the libvir-list mailing list