[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] mingw: fix build failure

On Sat, Nov 01, 2014 at 01:36:24AM +0100, Pavel Hrdina wrote:
On 10/31/2014 11:50 PM, Eric Blake wrote:
On 10/31/2014 12:13 PM, Pavel Hrdina wrote:
This macro seems to be defined only on linux/unix and it fails during
mingw build. Its value is '16' (taken from net/if.h) so define it if
it's not defined.

Signed-off-by: Pavel Hrdina <phrdina redhat com>

For now just define it for mingw but we should review all daemon related
code and not build it for mingw at all to save is those kind of failures.

Yeah, a better solution is probably worth the effort, but as we are
close to the release, and this is a reasonable bandage, I'm okay with
giving it ACK to go in for the release.

Thanks, pushed now.


  src/util/virnetdev.c | 4 ++++
  1 file changed, 4 insertions(+)

diff --git a/src/util/virnetdev.c b/src/util/virnetdev.c
index 6da3371..3831009 100644
--- a/src/util/virnetdev.c
+++ b/src/util/virnetdev.c
@@ -52,6 +52,10 @@
  # include <net/if_dl.h>

+#offender's IFNAMSIZ

Good things it's pushed without this "spell fix" :-D

+# define IFNAMSIZ 16


libvir-list mailing list
libvir-list redhat com

Attachment: signature.asc
Description: Digital signature

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]