[libvirt] [PATCH 1/2] qemu: Correct disk type checking logic for iothreads

Boris Fiuczynski fiuczy at linux.vnet.ibm.com
Thu Nov 6 14:04:04 UTC 2014


Finding the right type of disk should check for virtio as bus and
pci as device address type.

Signed-off-by: Boris Fiuczynski <fiuczy at linux.vnet.ibm.com>
Reviewed-by: Viktor Mihajlovski <mihajlov at linux.vnet.ibm.com>
---
 src/qemu/qemu_command.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 13b54dd..5b773ea 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@@ -3737,7 +3737,7 @@ qemuCheckIothreads(virDomainDefPtr def,
     }
 
     /* Right "type" of disk" */
-    if (disk->bus != VIR_DOMAIN_DISK_BUS_VIRTIO &&
+    if (disk->bus != VIR_DOMAIN_DISK_BUS_VIRTIO ||
         disk->info.type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_PCI) {
         virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
                        _("IOThreads only available for virtio pci disk"));
-- 
1.9.3





More information about the libvir-list mailing list