[libvirt] [PATCH] Fix a mismatch attribute name
Eric Blake
eblake at redhat.com
Fri Nov 7 09:15:11 UTC 2014
On 11/07/2014 09:24 AM, Luyao Huang wrote:
>>From libvirt.org we know this attribute named:
>
> interface_mac MAC address of the network interface, not unique
Shouldn't we instead be fixing the docs to match the code? Changing the
code now may break existing implementations that have used the name in
the current code.
>
> Signed-off-by: Luyao Huang <lhuang at redhat.com>
> ---
> src/access/viraccessdriverpolkit.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/access/viraccessdriverpolkit.c b/src/access/viraccessdriverpolkit.c
> index 3136be7..0e07053 100644
> --- a/src/access/viraccessdriverpolkit.c
> +++ b/src/access/viraccessdriverpolkit.c
> @@ -206,7 +206,7 @@ virAccessDriverPolkitCheckInterface(virAccessManagerPtr manager,
> const char *attrs[] = {
> "connect_driver", driverName,
> "interface_name", iface->name,
> - "interface_macaddr", iface->mac,
> + "interface_mac", iface->mac,
> NULL,
> };
>
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 539 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20141107/2140641e/attachment-0001.sig>
More information about the libvir-list
mailing list