[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 00/15] Cleanup some curly braces



On Thu, Nov 06, 2014 at 05:38:25PM +0100, Martin Kletzander wrote:
> There were unnecessary curly braces in few places (and the whole esx
> driver), so this series proposes fixing them.  As this couldn't be
> done automatically, there is no syntax-check.  We have to keep trying
> to eliminate that ;)

How did you go about identifying these places that needed fixing ?

I'm assunming you didn't do manual code inspection across everything.

While I like the intent, I share Eric's concern about doing this without
a syntax-check rule to prevent us re-introducing the problem

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]