[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] network: Add bandwidth support to ethernet interface

On 11/10/2014 03:41 PM, Anirban Chakraborty wrote:

>> BTW: it would be nice if you can version you patches. I mean, this is
>> what, 4th or 5th version? Say that in subject explicitly please. You
>> know, in the prefix: [PATCH v5] network: ...

Using 'git send-email -v5' will do that for you.

> I was doing it earlier and then dropped it. I¹ll resin the patch
> addressing all your comments and send it out. However, please let me know
> if I should move the above functions (virNetDevBandwidthSet etc.) in
> src/util/virnetdevbandwidth.* and add #include "conf/domain_conf.h" in
> virnetdevbandwidth.h file.

If it needs to reference structs defined in conf/, then the logical
place for the functions is in conf/ (possibly a new file).  That way, it
can still be shared between lxc and qemu.

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]