[libvirt] [libvirt-glib PATCH 2/2] Revert back deleted glib-specific warning options

Martin Kletzander mkletzan at redhat.com
Thu Nov 13 15:45:13 UTC 2014


Commit f525ba7796a2fd35bf55e88fb94459b2277fcd67 copied warning macros
from gnulib without keeping glib-specific settings.  This build-breaker
brings back those needed ones except unused-parameter, which is no
longer needed.

Signed-off-by: Martin Kletzander <mkletzan at redhat.com>
---
 m4/virt-compile-warnings.m4 | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/m4/virt-compile-warnings.m4 b/m4/virt-compile-warnings.m4
index 5081ab6..0cf67fa 100644
--- a/m4/virt-compile-warnings.m4
+++ b/m4/virt-compile-warnings.m4
@@ -124,6 +124,17 @@ AC_DEFUN([LIBVIRT_GLIB_COMPILE_WARNINGS],[
     dontwarn="$dontwarn -Woverlength-strings"
     dontwarn="$dontwarn -Wstack-protector"

+    # g_clear_object & G_ATOMIC_OP_USE_GCC_BUILTINS causes
+    # violations with this. XXX Fix glib ?
+    dontwarn="$dontwarn -Wbad-function-cast"
+
+    # Due to gutils.h bug in g_bit_storage
+    wantwarn="$wantwarn -Wno-sign-conversion"
+    wantwarn="$wantwarn -Wno-conversion"
+    # We can't enable this due to horrible spice_usb_device_get_description
+    # signature
+    wantwarn="$wantwarn -Wno-format-nonliteral"
+
     # Get all possible GCC warnings
     gl_MANYWARN_ALL_GCC([maybewarn])

-- 
2.1.3




More information about the libvir-list mailing list