[libvirt] [PATCH 0/2] use bool type for bool values

Michal Privoznik mprivozn at redhat.com
Wed Nov 19 13:05:19 UTC 2014


On 18.11.2014 01:36, Eric Blake wrote:
> I stumbled into this one on work I'm doing with qemu blockinfo.
> The DBus interaction code was tricky enough to need to be its own
> patch; but I like the end result that clients reading a 'b' entry
> from virDBus code can now pass a sane 'bool*' instead of a weird
> 'int*' variable.
>
> Eric Blake (2):
>    virdbus: don't force users to pass int for bool values
>    maint: forbid 'int foo = true'
>
>   cfg.mk                       |  6 ++++++
>   src/conf/snapshot_conf.c     |  2 +-
>   src/qemu/qemu_driver.c       |  4 ++--
>   src/test/test_driver.c       |  2 +-
>   src/util/vircgroup.c         |  2 +-
>   src/util/virdbus.c           | 25 ++++++++++++++-----------
>   src/util/virpci.c            |  2 +-
>   src/util/virpolkit.c         |  6 +++---
>   src/util/virutil.c           |  2 +-
>   tests/virdbustest.c          |  4 ++--
>   tools/virsh-domain-monitor.c |  2 +-
>   tools/virsh-domain.c         | 12 ++++++------
>   12 files changed, 39 insertions(+), 30 deletions(-)
>

ACK to both.

Michal




More information about the libvir-list mailing list