[libvirt] [PATCH 3/5] ip link needs 'name' in 3.16 to create the veth pair

[Richard Weinberger]

Am 26.11.2014 um 10:16 schrieb Cedric Bosdonnat:
> On Wed, 2014-11-26 at 09:34 +0100, Richard Weinberger wrote:
>> Am 26.11.2014 um 09:25 schrieb Cedric Bosdonnat:
>>> Hi Martin,
>>>
>>> On Wed, 2014-11-26 at 05:51 +0100, Martin Kletzander wrote:
>>>>> Instead of papering over the issue in libvirt better ship a non-broken iproute2
>>>>> in openSUSE 13.2.
>>>>> real fix: https://git.kernel.org/cgit/linux/kernel/git/shemminger/iproute2.git/commit/?id=f1b66ff
>>>>>
>>>>
>>>> Oh, thank you for finding that, I should've done my homework!  Since
>>>> it really is just a bug on iproute2 side in openSUSE, I'd rather keep
>>>> it in its original state.  And since the patch is already pushed, I'm
>>>> inclining to reverting it.
>>>>
>>>> Other opinions?
>>>
>>> Quoting a colleague of mine working on the network stack:
>>>
>>>     [this is] a regression in (upstream) iproute2 3.16, fixed in 3.17.  
>>>     bnc#907093 has been created for it. (Factory is also affected but a
>>>     submit request is already on its way.)
>>>
>>> So I think we should keep that for those running the buggy 3.16.
>>
>> openSUSE has to fix their package and to serve a bugfix update, full stop.
> 
> Thought that may not happen only to openSUSE... and that fix didn't harm
> at all.

Yes, but "fixing" this issue in libvirt is not correct.
It needs to be fixed in the right place and iproute2 this is.

libvirt is not the only user of this iproute2 feature.

Thanks,
//richard