[libvirt] [PATCH 3/5] ip link needs 'name' in 3.16 to create the veth pair

[Richard Weinberger]

Am 26.11.2014 um 14:23 schrieb Eric Blake:
> On 11/26/2014 02:25 AM, Richard Weinberger wrote:
> 
>>>>> So I think we should keep that for those running the buggy 3.16.
>>>>
>>>> openSUSE has to fix their package and to serve a bugfix update, full stop.
>>>
>>> Thought that may not happen only to openSUSE... and that fix didn't harm
>>> at all.
>>
>> Yes, but "fixing" this issue in libvirt is not correct.
>> It needs to be fixed in the right place and iproute2 this is.
>>
>> libvirt is not the only user of this iproute2 feature.
> 
> I agree that making all clients work around a bug is annoying; on the
> other hand, once a client has worked around it, I see no reason to force
> the client to have to revert, since the workaround is arguably more legible.

I agree that we don't have to force the revert.
But we have to be very sure that *every* iproute2 version understands the
new command line. I'm not an iproute2 expert, so I can't tell for sure.
I doubt I'd revert it. Distros which ship the broken iproute2 package have
to fix it anyways as a lot of other tools/scripts break too.

Thanks,
//richard