[libvirt] [PATCH v3 14/14] vbox: New network driver

Michal Privoznik mprivozn at redhat.com
Fri Oct 3 11:58:55 UTC 2014


On 03.10.2014 13:51, Ján Tomko wrote:
> On 10/02/2014 05:30 AM, Taowei wrote:
>> This patch seperate the domain driver and the network driver.
>>
>> libvirt_driver_vbox_impl.la has been linked in the network driver.
>> So that the version specified codes in vbox_V*.c would only be
>> compiled once.
>>
>> The vboxGetNetworkDriver provides a simple interface to get vbox
>> network driver.
>> ---
>>   src/Makefile.am               |   11 ++++--
>>   src/vbox/vbox_driver.c        |    9 +++--
>>   src/vbox/vbox_get_driver.h    |    1 +
>>   src/vbox/vbox_network.c       |   83 +++++++++++++++++++++++++++++++++--------
>>   src/vbox/vbox_tmpl.c          |   18 ---------
>>   src/vbox/vbox_uniformed_api.h |   16 --------
>>   6 files changed, 82 insertions(+), 56 deletions(-)
>>
>
> This patch broke the build without driver modules:
> ./autogen.sh --system --without-driver-modules && make
>
>    CCLD     libvirtd
> ../src/.libs/libvirt_driver_vbox.a(libvirt_driver_vbox_impl_la-vbox_driver.o):
> In function `vboxNetworkRegister':
> /home/jtomko/work/libvirt/libvirt.git/src/vbox/vbox_driver.c:168: undefined
> reference to `vboxGetNetworkDriver'
> collect2: error: ld returned 1 exit status
> make[3]: *** [libvirtd] Error 1
>

Oh right. Will push fix shortly.

Michal




More information about the libvir-list mailing list