[libvirt] [PATCH] Introduce virStringStripIPv6Brackets

[Ján Tomko]

On 10/08/2014 11:10 AM, Daniel P. Berrange wrote:
> On Wed, Oct 08, 2014 at 10:46:53AM +0200, Ján Tomko wrote:
>> Helper function to strip the brackets from an IPv6 address.
>> Tested by viruritest.
>> ---
>>  src/libvirt_private.syms |  1 +
>>  src/util/virstring.c     | 22 ++++++++++++++++++++++
>>  src/util/virstring.h     |  2 ++
>>  src/util/viruri.c        | 20 ++++----------------
>>  4 files changed, 29 insertions(+), 16 deletions(-)
> 
> Can we have tests in viruritest.c and virstringtest.c too
> 

We already test it on sane inputs in viruritest.

I've added some corner cases to virstringtest in v2.

> 
> Regards,
> Daniel
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20141008/929fb745/attachment-0001.sig>