[libvirt] [PATCHv3 00/16] Network configuration for lxc containers

[Daniel P. Berrange]

On Fri, Oct 10, 2014 at 03:13:10PM +0200, Richard Weinberger wrote:
> On Fri, Oct 10, 2014 at 2:03 PM, Cédric Bosdonnat <cbosdonnat at suse.com> wrote:
> > Hi all,
> >
> > Here is a rebased version of v2. Nothing changed except the 'since' version number
> > in the added doc that has been updated.
> >
> > --
> > Cedric
> >
> > Cédric Bosdonnat (16):
> >   Forgot to cleanup ifname_guest* in domain network def parsing
> >   Domain conf: allow more than one IP address for net devices
> >   LXC: set IP addresses to veth devices in the container
> >   lxc conf2xml: convert IP addresses
> >   Allow network capabilities hostdev to configure IP addresses
> >   lxc conf2xml: convert ip addresses for hostdev NICs
> >   Domain network devices can now have a <gateway> element
> >   lxc conf2xml: convert lxc.network.ipv[46].gateway
> >   LXC: use the new net devices gateway definition
> >   LXC: honour network devices link state
> >   Wrong place for virDomainNetIpsFormat
> >   virNetDevSetIPv4Address: libnl implementation
> >   Renamed virNetDevSetIPv4Address to virNetDevSetIPAddress
> >   virNetDevAddRoute: implementation using netlink
> >   virNetDevClearIPv4Address: netlink implementation
> >   Renamed virNetDevClearIPv4Address to virNetDevClearIPAddress
> 
> I still think that going down the netlink path is not optimal.
> As stated before in v2 you can just enter the network namespace and use
> the host tools to setup networking.
> This way no tools have to be installed within the container and we'd
> not depend on netlink with reinventing iproute2 tools.

We have a general aim to avoid using external commands if there are
APIs available todo the same job. It is less overhead, gives us better
error reporting and we're not susceptible to changes in the CLI tool
syntax. So I think using the netlink is actually the right thing
here. 

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|