[libvirt] [PATCHv2 1/2] util: Functions to update host network device's multicast filter

[Laine Stump]

On 10/14/2014 02:41 PM, Laine Stump wrote:
> I think you forgot to merge in your modifications from V1 - although the
> commit log is changed, the code is still the V1 patch :-)

Ah, I see that you sent the actual V2 patch last weekend, and only sent
this update to move the "changes from V1" message out of the commit log
message - I'll just review what you sent on Oct 10 - no need to resend
yet again. (Sorry I haven't already reviewed - I've been travelling
since last Thursday, and am currently in a conference room at KVM Forum).

>
>
> On 10/13/2014 03:52 PM, akrowiak at linux.vnet.ibm.com wrote:
>> From: Tony Krowiak <akrowiak at linux.vnet.ibm.com>
>>
>> This patch provides the utility functions to needed to synchronize the
>> changes made to a guest domain network device's multicast filter
>> with the corresponding macvtap device's filter on the host:
>>
>> * Get/add/remove multicast MAC addresses
>> * Get the macvtap device's RX filter list
>>
>> Signed-off-by: Tony Krowiak <akrowiak at linux.vnet.ibm.com>
>> ---
>>
>> Changes from V1:
>>
>> * Using virHexToBin function to parse HEX MAC address instead of
>>   sscanf in virMacAddrParseHex function
>> * Using ENOSYS in error messages for empty functions
>> * Reading entire file with virFileReadAll function when
>>   parsing /proc/net/dev_mcast file
>> * Using VIR_APPEND_ELEMENT macro when appending array of
>>   /proc/net/dev_mcast file objects
>> * Misc. formatting changes
>>
>>  src/libvirt_private.syms |    4 +
>>  src/util/virmacaddr.c    |   37 +++++
>>  src/util/virmacaddr.h    |    4 +
>>  src/util/virnetdev.c     |  360 ++++++++++++++++++++++++++++++++++++++++++++++
>>  src/util/virnetdev.h     |   11 ++
>>  5 files changed, 416 insertions(+), 0 deletions(-)
>>
>>