[libvirt] [PATCH/RFC] Add missing delta from Ubuntu to apparmor profiles

Stefan Bader stefan.bader at canonical.com
Sun Oct 19 11:07:40 UTC 2014


On 18.10.2014 23:12, intrigeri wrote:
> Hi,
> 
> Daniel P. Berrange wrote (01 Oct 2014 14:54:43 GMT) :
>> Agreed, the libvirt upstream distributed file should do version checks
>> based on official apparmor releases, and distros can tweak versions if
>> they have backported features.
> 
> So, it seems that we've reached a consensus that adding version
> checking machinery makes sense. Great :)
> 
> Stefan, do you plan to implement it? One way to go could be to
> implement and upload it first in Ubuntu: the rest of the delta is
> already there anyway, so it's not as if it changed the current
> situation much; and then, it also makes it easy to test the version
> checks on Debian, for added confidence, before submitting the
> patch upstream.
> 
> Note: once this machinery is in place, ideally distros should rebuild
> their libvirt binary packages when they introduce new AppArmor parser
> features -- which is effectively a transition, in Debian-speak.
> 
> Cheers,
> 
Yeah, I actually did but it felt a bit hackish but then I am told anything looks
a bit hackish when it involves autoconf. These are again against upstream
libvirt mostly because the last touch timestamps always clash otherwise. I tried
to do two steps, one introducing the machinery and the second to add the
changes. That way the vast looking delta of the first patch boils down to mostly
renames.

-Stefan


-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-examples-apparmor-Add-ability-to-add-versioned-featu.patch
Type: text/x-diff
Size: 28137 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20141019/0a7d0e4d/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-examples-apparmor-Update-profiles-with-Ubuntu-delta.patch
Type: text/x-diff
Size: 9474 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20141019/0a7d0e4d/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20141019/0a7d0e4d/attachment-0001.sig>


More information about the libvir-list mailing list