[libvirt] [PATCH] conf: tests: fix virDomainNetDefFormat for vhost-user in client mode

Peter Krempa pkrempa at redhat.com
Mon Oct 20 06:59:54 UTC 2014


On 10/17/14 18:45, Maxime Leroy wrote:
> The mode attribute is required for the source element of vhost-user. Thus
> virDomainNetDefFormat should always generate a xml with it, and
> not only when the mode is server.
> 
> The commit fixes the issue. And it adds a vhostuser interface in 'client' mode
> to qemuxml2argv-net-vhostuser.(args|xml) to test this usecase.
> 
> Signed-off-by: Maxime Leroy <maxime.leroy at 6wind.com>

I've reflowed your commit message to break a few long lines.


> ---
>  src/conf/domain_conf.c                                 | 5 +++--
>  tests/qemuxml2argvdata/qemuxml2argv-net-vhostuser.args | 7 +++++--
>  tests/qemuxml2argvdata/qemuxml2argv-net-vhostuser.xml  | 7 ++++++-
>  3 files changed, 14 insertions(+), 5 deletions(-)
> 

and pushed your patch. Thanks for taking time to provide a test case.

Peter


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20141020/380d4489/attachment-0001.sig>


More information about the libvir-list mailing list