[libvirt] [PATCH] tests: fix incorrect caps for shmem-invalid-size, shmem-small-size

Peter Krempa pkrempa at redhat.com
Mon Oct 20 07:03:25 UTC 2014


On 10/17/14 18:05, Maxime Leroy wrote:
> VIR_TEST_DEBUG=2 ./qemuxml2argvtest generates the following output:
> 
> 409) QEMU XML-2-ARGV shmem-invalid-size
> ... Got expected error: unsupported configuration: ivshmem device is not \
> 	 supported with this QEMU binary
> OK
> 410) QEMU XML-2-ARGV shmem-small-size
> ... Got expected error: unsupported configuration: ivshmem device is not \
> supported with this QEMU binary
> OK
> 
> We should have:
> 
> 409) QEMU XML-2-ARGV shmem-invalid-size
> ... Got expected error: XML error: shmem size must be a power of two
> OK
> 410) QEMU XML-2-ARGV shmem-small-size
> ... Got expected error: XML error: shmem size must be at least 1 MiB
> OK
> 
> This commit fixes the issue by providing QEMU_CAPS_DEVICE_IVSHMEM caps
> for shmem-invalid-size, shmem-small-size test.
> 
> Signed-off-by: Maxime Leroy <maxime.leroy at 6wind.com>
> ---
>  tests/qemuxml2argvtest.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 

Nice catch! ACK and pushed.

Thanks

Peter


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20141020/7594a150/attachment-0001.sig>


More information about the libvir-list mailing list