[libvirt] [PATCH 0/3] Fix handling of data returned by XML hooks

Martin Kletzander mkletzan at redhat.com
Wed Oct 22 13:01:41 UTC 2014


On Wed, Oct 22, 2014 at 11:48:03AM +0200, Peter Krempa wrote:
>Peter Krempa (3):
>  util: string: Add helper to check whether string is empty
>  qemu: restore: Fix restoring of VM when the restore hook returns empty
>    XML
>  qemu: migration: Make check for empty hook XML robust
>
> src/libvirt_private.syms  |  1 +
> src/qemu/qemu_driver.c    |  2 +-
> src/qemu/qemu_migration.c |  2 +-
> src/util/virstring.c      | 16 ++++++++++++++++
> src/util/virstring.h      |  2 ++
> 5 files changed, 21 insertions(+), 2 deletions(-)
>
>--
>2.1.0
>

You're still missing one check in qemuDomainObjRestore(), but it's the
last one.  Fixing this in virHookCall() seems to make it unnecessarily
complicated.  ACK if you fix qemuDomainObjRestore() as well.

Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20141022/75c77cf6/attachment-0001.sig>


More information about the libvir-list mailing list