[libvirt] [PATCH 04/12] Move virNetwork related APIs out of libvirt.c

Eric Blake eblake at redhat.com
Thu Oct 23 04:20:24 UTC 2014


On 10/22/2014 11:14 AM, Daniel P. Berrange wrote:
> Introduce a src/libvirt-network.c file to hold all the
> methods related to the virNetwork type.
> ---
>  docs/apibuild.py      |    1 +
>  po/POTFILES.in        |    1 +
>  src/Makefile.am       |    2 +
>  src/libvirt-network.c | 1251 +++++++++++++++++++++++++++++++++++++++++++++++++
>  src/libvirt.c         | 1221 -----------------------------------------------
>  5 files changed, 1255 insertions(+), 1221 deletions(-)
>  create mode 100644 src/libvirt-network.c
> 

> +++ b/src/libvirt-network.c

> +
> +VIR_LOG_INIT("libvirt.network");
> +
> +#define VIR_FROM_THIS VIR_FROM_NONE
> +

Same comment as in 3/12 - do we want to update this to be more specific
than VIR_FROM_NONE?

Otherwise, I did the same review as mentioned in 2/12; it is just code
motion.

ACK.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 539 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20141022/c5e3c650/attachment-0001.sig>


More information about the libvir-list mailing list