[libvirt] [PATCH 1/n] dumpxml: add flag to virDomainGetXMLDesc
Adam Litke
alitke at redhat.com
Thu Oct 23 13:52:01 UTC 2014
On 17/09/14 08:43 -0600, Eric Blake wrote:
>+ * If @flags contains VIR_DOMAIN_XML_BLOCK_INFO, the listing for each
>+ * <disk> device will contain additional information such as capacity
>+ * and allocation, similar to what is displayed by virStorageVolGetXMLDesc(),
>+ * and avoiding the need to call virDomainGetBlockInfo() separately.
>+ *
Eric: We decided to go with this extra flag since gathering the block
info was seen as a potentially expensive operation which users would
want to selectively enable. Do you have any thoughts on how expensive
this would be in practice? We are considering enabling it
unconditionally in oVirt and am weighing a decision between A)
Simplicity and Cacheability vs. B) Performance.
Thanks.
--
Adam Litke
More information about the libvir-list
mailing list