[libvirt] [PATCH] vbox: network: make sure driver not be NULL in virRegisterNetworkDriver

[Eric Blake]

On 10/24/2014 10:17 AM, Shanzhi Yu wrote:
> 

>>>
>>> if (networkDriver && virRegisterNetworkDriver(networkDriver) < 0)
>> ACK to this.
>>
>>> Or did you botch the logic, and really mean:
>>>
>>> if (!networkDriver || virRegisterNetworkDriver(networkDriver) < 0)
>>>
>>> Furthermore, Dan's recent patch series will probably overhaul all of
>>> this anyways, so it may be easier to just wait for his patches to land.
> 
> Thanks for your review. I mean the && not ||.
> 
>> No, the logic in the patch is correct. We don't want an error if the
>> networkDriver is NULL. We just want to continue running without
>> any error in that case.
>>
>> We should push this now because we'll want to cherry pick it to stable
>> branches.

Pushed with some minor grammar tweaks to the commit message.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 539 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20141024/e455868d/attachment-0001.sig>