[libvirt] [PATCH v2] esx: Simplify VI (vSphere) API and VMware product version handling
Eric Blake
eblake at redhat.com
Fri Oct 24 18:09:10 UTC 2014
On 10/18/2014 04:08 PM, Matthias Bolte wrote:
> Store version numbers in this format
>
> version = 1000000 * major + 1000 * minor + micro
>
> produced by virParseVersionString instead of dedicated enums.
>
> Split the complex esxVI_ProductVersion enum into a simpler
> esxVI_ProductLine enum and a product version number.
>
> Relax API and product version number checks to accept everything that
> is equal or greater than the supported minimum version. VMware ESX
> went through 3 major versions and the vSphere API always stayed
> backward compatible. This commit assumes that this will also be true
> for future VMware ESX versions.
>
> Also reword error messages in esxConnectTo* to say what was expected
> and what was found instead (suggested by Richard W.M. Jones).
> ---
>
> v2: - Fix copy&paste accident that replaced hostname with conn->uri->server
> in esxConnectToVCenter
> - Fix and improve commit message
>
> src/esx/esx_driver.c | 59 +++++---------
> src/esx/esx_vi.c | 215 ++++++++++++++++++++++++++-------------------------
> src/esx/esx_vi.h | 55 +++----------
> 3 files changed, 140 insertions(+), 189 deletions(-)
>
ACK
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 539 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20141024/38abe226/attachment-0001.sig>
More information about the libvir-list
mailing list