[libvirt] [PATCH] qemu: forbid snapshot-delete --children-only on external snapshot

[Eric Blake]

On 10/27/2014 09:14 AM, Kashyap Chamarthy wrote:
> On Mon, Oct 27, 2014 at 05:44:29AM -0600, Eric Blake wrote:
>> https://bugzilla.redhat.com/show_bug.cgi?id=956506 documents that
>> given a domain where an internal snapshot parent has an external
>> snapshot child, we lacked a safety check when trying to use the
>> --children-only option to snapshot-delete:
>>

>> While I'd still like to see patches that actually do proper external
>> snapshot deletion, we should at least fix the inconsistency in the
>> meantime.  With this patch:
>>
>> $ virsh snapshot-delete dom internal --children-only
>> error: Failed to delete snapshot internal
>> error: unsupported configuration: deletion of 1 external disk snapshots not supported yet
>>
>> * src/qemu/qemu_driver.c (qemuDomainSnapshotDelete): Fix condition.
>>

> 
> FWIW, Tested-By: Kashyap Chamarthy <kchamart at redhat.com>
> 
> I used the same method as you, after applying the patch manually from
> the list (and made RPMs):

I've gone ahead and pushed this patch.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 539 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20141027/19146ba8/attachment-0001.sig>