[libvirt] [PATCH] qemu_agent: Produce more readable error messages

[Eric Blake]

On 10/27/2014 08:59 PM, Michal Privoznik wrote:
> Not every error message from qemu-ga has to have the 'class' field
> filled out. For instance, I've seen this error message lately:

Is that a bug in qemu-ga?  Worth asking on the qemu list.  But we have
to deal with it in the meantime, so this patch is still worthwhile.

> 
>   qemuAgentCheckError:1047 : unable to execute QEMU agent command \
>   {"execute":"guest-set-time"}: \
>   {"error":{"desc":"Invalid parameter type, expected: integer"}}
> 
> However, this got translated into rather generic error message:
> 
>   internal error: unable to execute QEMU agent command
>   'guest-set-time': unknown QEMU command error
> 
> So we've dropped better error message in favor of a generic one.
> This is due to our code which expects 'class' which is not
> present here.
> 

ACK.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 539 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20141028/56af94ca/attachment-0001.sig>