[libvirt] [PATCH python] fix libvirt headers list

Eric Blake eblake at redhat.com
Tue Oct 28 17:15:20 UTC 2014


On 10/28/2014 10:58 AM, Dmitry Guryanov wrote:
> Since libvirt.h has been splitted out, generator.py

s/splitted/split/

> should be fixed accordingly. So add full list of header
> files.
> 

Does this still work when targetting older libvirt prior to the header
split?  If so, then ACK.

>  
> +libvirt_headers = ["libvirt",
> +                   "libvirt-domain",
> +                   "libvirt-domain-snapshot",
> +                   "libvirt-event",
> +                   "libvirt-host",
> +                   "libvirt-interface",
> +                   "libvirt-network",
> +                   "libvirt-nodedev",
> +                   "libvirt-nwfilter",
> +                   "libvirt-secret",
> +                   "libvirt-storage",
> +                   "libvirt-stream",]

Might be worth putting the ] on its own line; then, if we add new files
in the future, it will be a one line addition instead of having to
modify an existing line.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 539 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20141028/1600a2f4/attachment-0001.sig>


More information about the libvir-list mailing list