[libvirt] [PATCH 0/7] static zero initialization

Michal Privoznik mprivozn at redhat.com
Tue Oct 28 21:55:22 UTC 2014


On 28.10.2014 21:34, Eric Blake wrote:
> Based on a comment I just made while reviewing Dan's patches,
> we might as well adopt a consistent style of relying on the
> C guarantee that static variables are automatically
> zero-initialized without any effort on our part.
>
> Eric Blake (7):
>    audit: use bool for audit log choice
>    maint: avoid static zero init in core files
>    maint: avoid static zero init in tools
>    maint: avoid static zero init in tests
>    maint: avoid static zero init in helpers
>    maint: avoid static zero init in drivers
>    maint: add syntax check to prohibit static zero init
>
>   cfg.mk                                  |  8 ++++++++
>   daemon/libvirtd.c                       |  2 +-
>   src/conf/nwfilter_conf.c                |  2 +-
>   src/cpu/cpu_x86.c                       |  2 +-
>   src/interface/interface_backend_netcf.c |  2 +-
>   src/libvirt.c                           | 18 +++++++++---------
>   src/libxl/libxl_driver.c                |  2 +-
>   src/locking/lock_daemon.c               |  2 +-
>   src/locking/lock_driver_lockd.c         |  4 ++--
>   src/locking/lock_driver_sanlock.c       |  2 +-
>   src/lxc/lxc_controller.c                |  2 +-
>   src/network/bridge_driver.c             |  2 +-
>   src/node_device/node_device_udev.c      |  2 +-
>   src/nwfilter/nwfilter_learnipaddr.c     |  2 +-
>   src/openvz/openvz_util.c                |  4 ++--
>   src/phyp/phyp_driver.c                  |  8 +++++---
>   src/qemu/qemu_driver.c                  |  5 +++--
>   src/remote/remote_driver.c              |  2 +-
>   src/rpc/virnetserver.c                  |  4 ++--
>   src/security/security_selinux.c         |  2 +-
>   src/test/test_driver.c                  |  2 +-
>   src/uml/uml_driver.c                    |  2 +-
>   src/util/viralloc.c                     | 10 +++++-----
>   src/util/viraudit.c                     |  4 ++--
>   src/util/viraudit.h                     |  4 ++--
>   src/util/virdbus.c                      |  4 ++--
>   src/util/virevent.c                     | 14 +++++++-------
>   src/util/virfile.c                      |  2 +-
>   src/util/virlog.c                       | 16 ++++++++--------
>   src/util/virnetlink.c                   |  2 +-
>   src/util/virprocess.c                   |  3 +--
>   src/util/virthread.h                    |  4 ++--
>   src/vbox/vbox_XPCOMCGlue.c              |  4 ++--
>   src/vbox/vbox_tmpl.c                    |  2 +-
>   src/xen/xen_driver.c                    |  4 ++--
>   src/xen/xen_hypervisor.c                |  4 ++--
>   tests/eventtest.c                       |  6 +++---
>   tests/testutils.c                       | 12 ++++++------
>   tests/virhostdevtest.c                  |  2 +-
>   tests/virportallocatortest.c            |  2 +-
>   tests/virscsitest.c                     |  2 +-
>   tools/virsh-console.c                   |  5 +----
>   tools/virsh-domain.c                    |  2 +-
>   tools/virsh.c                           |  4 ++--
>   tools/virt-host-validate-common.c       |  4 ++--
>   45 files changed, 102 insertions(+), 95 deletions(-)
>

ACK

Michal




More information about the libvir-list mailing list